FIX: Restore CI compilation broken by stale Wrench 1.x platform override#2450
Merged
Conversation
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Harness Review
Targeted compatibility fix. I checked the surrounding CI settings, recipe consumers, and generated Yamato jobs and did not find a substantiated behavioral regression from removing the stale package-level Mac override.
Reviewed commit d8604043
🤖 Helpful? 👍/👎
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2450 +/- ##
========================================
Coverage 78.95% 78.95%
========================================
Files 767 767
Lines 140780 140780
========================================
+ Hits 111147 111153 +6
+ Misses 29633 29627 -6 Flags with carried forward coverage won't be shown. Click here to find out more. |
VeraMommersteeg
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Wrench job failed to compile InputSystem.Cookbook with:
Introduced by: https://github.com/Unity-Technologies/InputSystem/pull/2402/changes#diff-6adf83bfcc4d79145f07fd4cb68146078ca080ea086346f67afa591278bf8186
Since there's no mentions of it anywhere there I assume this was a mistake addition and claude agrees (but of course don't trust it and opinions are welcome)
Testing status & QA
CI only
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
I'm not 100% sure if it was better to try and rework this or removing it was the right call. Opinions on that are needed
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.